chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java - Issue 2206613002: [TTS] Update the Tap Event Test to support Translations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java

Issue 2206613002: [TTS] Update the Tap Event Test to support Translations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Matt's feedback - made TranslationController protects in CS Manager. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java

index 307d1bebc16e677d68c7e6506c933d5931a93a7e..35ac2aeb4fc1859642477f5f24eaab9b3a30d89b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java

@@ -186,7 +186,7 @@ public class ContextualSearchTranslateController {

/**

* @return The accept-languages string from the cache or from native code (when not cached).

- private String getNativeAcceptLanguages() {

+ protected String getNativeAcceptLanguages() {

if (mAcceptLanguages == null) {

mAcceptLanguages = mHost.getAcceptLanguages();

}

@@ -197,7 +197,7 @@ public class ContextualSearchTranslateController {

* @return The Translate Service's target language string from the cache or from

* native code (when not cached).

- private String getNativeTranslateServiceTargetLanguage() {

+ protected String getNativeTranslateServiceTargetLanguage() {

if (mTranslateServiceTargetLanguage == null) {

mTranslateServiceTargetLanguage = mHost.getTranslateServiceTargetLanguage();

}