Sloppy eval declarations should not shadow lexical function declarations

Sloppy eval declarations should not shadow lexical function declarations

This was being allowed due to the use of BindingFlags instead of VariableMode
to determine whether a looked-up binding was lexical. Because function
declarations are hoisted, they never need hole checks, and so were being
miscategorized as non-lexical.

This patch augments Context::Lookup with a VariableMode out param, which
allows this check to determine precisely whether the binding is lexical.

BUG=v8:4454, v8:5256
Committed: https://crrev.com/83b63c308a38a156bf376a7babbd89ba2573b426
Cr-Commit-Position: refs/heads/master@{#38260}

[adamk, 2016-08-02 19:30:59]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:31:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-02 19:31:12]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:52:49]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-08-02 20:08:32]

lgtm

Nice clean fix to this oversight of mine!

[adamk, 2016-08-02 20:19:57]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:20:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:22:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-02 20:27:51]

Description was changed from

==========
Sloppy eval declarations should not shadow lexical function declarations

This was being allowed due to the use of BindingFlags instead of VariableMode
to determine whether a looked-up binding was lexical. Because function
declarations are hoisted, they never need hole checks, and so were being
miscategorized as non-lexical.

This patch augments Context::Lookup with a VariableMode out param, which
allows this check to determine precisely whether the binding is lexical.

BUG=v8:4454, v8:5256
==========

to

==========
Sloppy eval declarations should not shadow lexical function declarations

This was being allowed due to the use of BindingFlags instead of VariableMode
to determine whether a looked-up binding was lexical. Because function
declarations are hoisted, they never need hole checks, and so were being
miscategorized as non-lexical.

This patch augments Context::Lookup with a VariableMode out param, which
allows this check to determine precisely whether the binding is lexical.

BUG=v8:4454, v8:5256

Committed: https://crrev.com/83b63c308a38a156bf376a7babbd89ba2573b426
Cr-Commit-Position: refs/heads/master@{#38260}
==========

[commit-bot: I haz the power, 2016-08-02 20:27:51]

Patchset 1 (id:??) landed as
https://crrev.com/83b63c308a38a156bf376a7babbd89ba2573b426
Cr-Commit-Position: refs/heads/master@{#38260}