Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2200303002: Replace BindingFlags enum with InitializationFlag enum (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
neis, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-lexical-test
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace BindingFlags enum with InitializationFlag enum They may have once been different, but they're now redundant with each other. This simplifies both Context::Lookup and its callers. Committed: https://crrev.com/bb97d27abc19044bcf63fa60f89e59a6b6cac595 Cr-Commit-Position: refs/heads/master@{#38261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -115 lines) Patch
M src/contexts.h View 2 chunks +1 line, -34 lines 0 comments Download
M src/contexts.cc View 8 chunks +16 lines, -56 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 7 chunks +17 lines, -25 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
adamk
4 years, 4 months ago (2016-08-02 19:54:03 UTC) #2
Toon Verwaest
lgtm, nice simplification!
4 years, 4 months ago (2016-08-02 20:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200303002/1
4 years, 4 months ago (2016-08-02 20:35:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 20:36:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 20:37:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb97d27abc19044bcf63fa60f89e59a6b6cac595
Cr-Commit-Position: refs/heads/master@{#38261}

Powered by Google App Engine
This is Rietveld 408576698