Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2206343002: Add metrics for YouTube Flash embed rewrite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layers
Patch Set: Addressed comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.h
diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h
index c37ad3f03420b0b793da1e6f9e406e85ea1ea2bb..564cc5a899b21c3c045302eb8671b2d6887959d1 100644
--- a/chrome/renderer/chrome_content_renderer_client.h
+++ b/chrome/renderer/chrome_content_renderer_client.h
@@ -78,6 +78,26 @@ class WebSecurityOrigin;
class WebRtcLoggingMessageFilter;
#endif
+namespace internal {
+
+extern const char kFlashYouTubeRewriteUMA[];
+
+// Used for UMA. Values should not be reorderer or reused.
+// SUCCESS refers to an embed properly rewritten. SUCCESS_PARAMS_REWRITE refers
+// to an embed rewritten with the params fixed. SUCCESS_ENABLEJSAPI refers to
+// a rewritten embed even though the JS API was enabled (Chrome Android only).
+// FAILURE_ENABLEJSAPI indicates the embed was not rewritten because the
+// JS API was enabled.
+enum YouTubeRewriteStatus {
+ SUCCESS = 0,
+ SUCCESS_PARAMS_REWRITE = 1,
+ SUCCESS_ENABLEJSAPI = 2,
+ FAILURE_ENABLEJSAPI = 3,
+ NUM_PLUGIN_ERROR // should be kept last
+};
+
+} // namespace internal
+
class ChromeContentRendererClient : public content::ContentRendererClient {
public:
ChromeContentRendererClient();
@@ -166,7 +186,6 @@ class ChromeContentRendererClient : public content::ContentRendererClient {
int embedded_worker_id,
const GURL& url) override;
bool ShouldEnforceWebRTCRoutingPreferences() override;
-
GURL OverrideFlashEmbedWithHTML(const GURL& url) override;
#if defined(ENABLE_SPELLCHECK)
« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698