Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4453)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2206343002: Add metrics for YouTube Flash embed rewrite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layers
Patch Set: Addressed comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index c29b32bb608ed9a80060e733b65189ed32d12954..ef54c5d223bb595ed1588d81f1e22f74d81ff5c9 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -183,8 +183,17 @@ using content::RenderThread;
using content::WebPluginInfo;
using extensions::Extension;
+namespace internal {
+const char kFlashYouTubeRewriteUMA[] = "Plugin.Flash.YouTubeRewrite";
+} // namespace internal
+
namespace {
+void RecordYouTubeRewriteUMA(internal::YouTubeRewriteStatus status) {
+ UMA_HISTOGRAM_ENUMERATION(internal::kFlashYouTubeRewriteUMA, status,
+ internal::NUM_PLUGIN_ERROR);
+}
+
// Whitelist PPAPI for Android Runtime for Chromium. (See crbug.com/383937)
#if defined(ENABLE_PLUGINS)
const char* const kPredefinedAllowedCameraDeviceOrigins[] = {
@@ -1438,8 +1447,10 @@ GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) {
// We don't modify any URLs that contain the enablejsapi=1 parameter
// since the page may be interacting with the YouTube Flash player in
// Javascript and we don't want to break working content.
- if (corrected_url.query().find("enablejsapi=1") != std::string::npos)
+ if (corrected_url.query().find("enablejsapi=1") != std::string::npos) {
+ RecordYouTubeRewriteUMA(internal::FAILURE_ENABLEJSAPI);
return GURL();
+ }
// Change the path to use the YouTube HTML5 API
std::string path = corrected_url.path();
@@ -1448,5 +1459,7 @@ GURL ChromeContentRendererClient::OverrideFlashEmbedWithHTML(const GURL& url) {
url::Replacements<char> r;
r.SetPath(path.c_str(), url::Component(0, path.length()));
+ RecordYouTubeRewriteUMA(invalid_url ? internal::SUCCESS_PARAMS_REWRITE
+ : internal::SUCCESS);
return corrected_url.ReplaceComponents(r);
}
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_content_renderer_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698