Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4468)

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2206343002: Add metrics for YouTube Flash embed rewrite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layers
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.h
diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h
index 2c08a4d2e4c1bee3a4c2a9f5077a84d74aef1f50..a5214c98807753ad87dc37e54dc1074cbea14af6 100644
--- a/chrome/renderer/chrome_content_renderer_client.h
+++ b/chrome/renderer/chrome_content_renderer_client.h
@@ -74,6 +74,18 @@ class WebSecurityOrigin;
class WebRtcLoggingMessageFilter;
#endif
+namespace internal {
Alexei Svitkine (slow) 2016/08/08 11:32:35 Nit add blank lines within this.
kdsilva 2016/08/08 19:10:20 Done.
+extern const char kFlashYouTubeRewriteUMA[];
+// Used for UMA. Values should not be reorderer or reused.
+enum YouTubeRewriteStatus {
+ SUCCESS = 0,
+ SUCCESS_PARAMS_REWRITE = 1,
+ SUCCESS_ENABLEJSAPI = 2,
+ FAILURE_ENABLEJSAPI = 3,
+ NUM_PLUGIN_ERROR // should be kept last
+};
+} // namespace internal
Alexei Svitkine (slow) 2016/08/08 11:32:35 There should be 2 spaces before the comment.
kdsilva 2016/08/08 19:10:20 Done.
+
class ChromeContentRendererClient : public content::ContentRendererClient {
public:
ChromeContentRendererClient();
@@ -162,7 +174,6 @@ class ChromeContentRendererClient : public content::ContentRendererClient {
int embedded_worker_id,
const GURL& url) override;
bool ShouldEnforceWebRTCRoutingPreferences() override;
-
mlamouri (slow - plz ping) 2016/08/08 12:40:28 nit: I assume this change wasn't intentional?
kdsilva 2016/08/08 19:10:20 Ack. Removed unnecessary line I had added.
GURL OverrideFlashEmbedWithHTML(const GURL& url) override;
#if defined(ENABLE_SPELLCHECK)
« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698