Add metrics for YouTube Flash embed rewrite.

chrome/renderer/chrome_content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_
 #define CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 56 matching lines @@
 }
 
 namespace blink {
 class WebSecurityOrigin;
 }
 
 #if defined(ENABLE_WEBRTC)
 class WebRtcLoggingMessageFilter;
 #endif
 
+namespace internal {

[Alexei Svitkine (slow), 2016/08/08 11:32:35]

Nit add blank lines within this.

[kdsilva, 2016/08/08 19:10:20]

Done.

+extern const char kFlashYouTubeRewriteUMA[];
+// Used for UMA. Values should not be reorderer or reused.
+enum YouTubeRewriteStatus {
+  SUCCESS = 0,
+  SUCCESS_PARAMS_REWRITE = 1,
+  SUCCESS_ENABLEJSAPI = 2,
+  FAILURE_ENABLEJSAPI = 3,
+  NUM_PLUGIN_ERROR  // should be kept last
+};
+} // namespace internal

[Alexei Svitkine (slow), 2016/08/08 11:32:35]

There should be 2 spaces before the comment.

[kdsilva, 2016/08/08 19:10:20]

Done.

+
 class ChromeContentRendererClient : public content::ContentRendererClient {
  public:
   ChromeContentRendererClient();
   ~ChromeContentRendererClient() override;
 
   void RenderThreadStarted() override;
   void RenderFrameCreated(content::RenderFrame* render_frame) override;
   void RenderViewCreated(content::RenderView* render_view) override;
   SkBitmap* GetSadPluginBitmap() override;
   SkBitmap* GetSadWebViewBitmap() override;
@@ skipping 68 matching lines @@
   void RunScriptsAtDocumentEnd(content::RenderFrame* render_frame) override;
   void DidInitializeServiceWorkerContextOnWorkerThread(
       v8::Local<v8::Context> context,
       int embedded_worker_id,
       const GURL& url) override;
   void WillDestroyServiceWorkerContextOnWorkerThread(
       v8::Local<v8::Context> context,
       int embedded_worker_id,
       const GURL& url) override;
   bool ShouldEnforceWebRTCRoutingPreferences() override;
-

[mlamouri (slow - plz ping), 2016/08/08 12:40:28]

nit: I assume this change wasn't intentional?

[kdsilva, 2016/08/08 19:10:20]

Ack. Removed unnecessary line I had added.

   GURL OverrideFlashEmbedWithHTML(const GURL& url) override;
 
 #if defined(ENABLE_SPELLCHECK)
   // Sets a new |spellcheck|. Used for testing only.
   // Takes ownership of |spellcheck|.
   void SetSpellcheck(SpellCheck* spellcheck);
 #endif
 
 #if defined(ENABLE_PLUGINS)
   static blink::WebPlugin* CreatePlugin(
@@ skipping 50 matching lines @@
 #if defined(ENABLE_PRINT_PREVIEW)
   std::unique_ptr<ChromePDFPrintClient> pdf_print_client_;
 #endif
 #if defined(ENABLE_PLUGINS)
   std::set<std::string> allowed_camera_device_origins_;
   std::set<std::string> allowed_compositor_origins_;
 #endif
 };
 
 #endif  // CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_