Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2206323002: List items should not be clickable unless they have a mouse listener attached. (Closed)

Created:
4 years, 4 months ago by nektarios
Modified:
4 years, 4 months ago
Reviewers:
dmazzoni, aboxhall
CC:
dmazzoni, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

List items should not be clickable unless they have a mouse listener attached. R=dmazzoni@chromium.org, aboxhall@chromium.org TESTED=Manually with Jaws and NVDA Committed: https://crrev.com/15e832bb1b317e4e5f2da07369a9fec80536327b Cr-Commit-Position: refs/heads/master@{#410906}

Patch Set 1 #

Patch Set 2 : Fixed layout test. #

Patch Set 3 : fiFixed test. #

Patch Set 4 : Fixed test. #

Patch Set 5 : Fixed blank line in test expectations file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/press-works-on-control-types.html View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/press-works-on-control-types-expected.txt View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 35 (18 generated)
nektarios
4 years, 4 months ago (2016-08-03 17:14:14 UTC) #1
dmazzoni
lgtm
4 years, 4 months ago (2016-08-03 20:32:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/1
4 years, 4 months ago (2016-08-03 20:32:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/267005)
4 years, 4 months ago (2016-08-03 22:52:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/1
4 years, 4 months ago (2016-08-03 22:56:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/267130)
4 years, 4 months ago (2016-08-04 00:20:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/20001
4 years, 4 months ago (2016-08-08 19:20:34 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/275997)
4 years, 4 months ago (2016-08-08 20:37:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/40001
4 years, 4 months ago (2016-08-08 21:16:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/276081)
4 years, 4 months ago (2016-08-08 22:33:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/60001
4 years, 4 months ago (2016-08-08 22:46:21 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/179969)
4 years, 4 months ago (2016-08-08 23:10:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/60001
4 years, 4 months ago (2016-08-09 04:54:10 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/273894)
4 years, 4 months ago (2016-08-09 06:35:05 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206323002/80001
4 years, 4 months ago (2016-08-09 23:10:34 UTC) #32
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-10 00:58:19 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 01:00:29 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/15e832bb1b317e4e5f2da07369a9fec80536327b
Cr-Commit-Position: refs/heads/master@{#410906}

Powered by Google App Engine
This is Rietveld 408576698