Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2206323002: List items should not be clickable unless they have a mouse listener attached. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed blank line in test expectations file. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/press-works-on-control-types-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1975 matching lines...) Expand 10 before | Expand all | Expand 10 after
1986 return toElement(node); 1986 return toElement(node);
1987 1987
1988 switch (roleValue()) { 1988 switch (roleValue()) {
1989 case ButtonRole: 1989 case ButtonRole:
1990 case PopUpButtonRole: 1990 case PopUpButtonRole:
1991 case ToggleButtonRole: 1991 case ToggleButtonRole:
1992 case TabRole: 1992 case TabRole:
1993 case MenuItemRole: 1993 case MenuItemRole:
1994 case MenuItemCheckBoxRole: 1994 case MenuItemCheckBoxRole:
1995 case MenuItemRadioRole: 1995 case MenuItemRadioRole:
1996 case ListItemRole:
1997 return toElement(node); 1996 return toElement(node);
1998 default: 1997 default:
1999 break; 1998 break;
2000 } 1999 }
2001 2000
2002 Element* anchor = anchorElement(); 2001 Element* anchor = anchorElement();
2003 Element* clickElement = mouseButtonListener(); 2002 Element* clickElement = mouseButtonListener();
2004 if (!anchor || (clickElement && clickElement->isDescendantOf(anchor))) 2003 if (!anchor || (clickElement && clickElement->isDescendantOf(anchor)))
2005 return clickElement; 2004 return clickElement;
2006 return anchor; 2005 return anchor;
(...skipping 834 matching lines...) Expand 10 before | Expand all | Expand 10 after
2841 return placeholder; 2840 return placeholder;
2842 } 2841 }
2843 2842
2844 DEFINE_TRACE(AXNodeObject) 2843 DEFINE_TRACE(AXNodeObject)
2845 { 2844 {
2846 visitor->trace(m_node); 2845 visitor->trace(m_node);
2847 AXObject::trace(visitor); 2846 AXObject::trace(visitor);
2848 } 2847 }
2849 2848
2850 } // namespace blink 2849 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/press-works-on-control-types-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698