Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Skia is moving to returning smart pointers when creating an SkData.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7eefc9a19b85a7bfb10162351a176868b6caeacf
Cr-Commit-Position: refs/heads/master@{#409985}

[bungeman-chromium, 2016-08-03 18:19:21]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Skia is moving to returning smart pointers when creating an SkData.
==========

to

==========
Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Skia is moving to returning smart pointers when creating an SkData.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[bungeman-chromium, 2016-08-03 18:25:02]

The CQ bit was checked by bungeman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:25:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-chromium, 2016-08-03 18:44:33]

bungeman@chromium.org changed reviewers:
+ enne@chromium.org, fmalita@chromium.org, wez@chromium.org

[bungeman-chromium, 2016-08-03 18:44:34]

enne: cc/ and content/
fmalita: WebKit/
wez: blimp/

The Chromium side of this is fairly trivial. The WebKit side is a little more
involved.

[bungeman-chromium, 2016-08-03 18:50:42]

The CQ bit was checked by bungeman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-chromium, 2016-08-03 18:52:00]

bungeman@chromium.org changed reviewers:
+ miguelg@chromium.org

[bungeman-chromium, 2016-08-03 18:52:01]

miguelg: chrome/browser/android/

[Wez, 2016-08-03 18:54:54]

blimp/ LGTM

[Wez, 2016-08-03 18:54:57]

blimp/ LGTM

[f(malita), 2016-08-03 19:23:05]

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(left):

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:131:
WTF::adopted(data);
Nice to see this gone!

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(right):

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:130:
RefPtr<SegmentReader> segmentReader =
SegmentReader::createFromSkData(sk_sp<SkData>(data));
Shouldn't this be sk_ref_sp(data)?

The prev variant takes a PassRefPtr, and the implicit PassRefPtr<T*> ctor grabs
a new ref off the bare pointer.  Here it appears we're adopting instead.

(ideally the create param should also be a smart pointer, that would help
clarify what's going on here)

[bungeman-chromium, 2016-08-03 19:37:54]

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
(right):

https://codereview.chromium.org/2206263003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp:130:
RefPtr<SegmentReader> segmentReader =
SegmentReader::createFromSkData(sk_sp<SkData>(data));
On 2016/08/03 19:23:05, f(malita) wrote:
> Shouldn't this be sk_ref_sp(data)?
> 
> The prev variant takes a PassRefPtr, and the implicit PassRefPtr<T*> ctor
grabs
> a new ref off the bare pointer.  Here it appears we're adopting instead.
> 
> (ideally the create param should also be a smart pointer, that would help
> clarify what's going on here)

After taking a closer look, I think you're right here.

Done.

[bungeman-chromium, 2016-08-03 19:38:31]

The CQ bit was checked by bungeman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 19:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-08-03 19:56:20]

lgtm

LGTM

[commit-bot: I haz the power, 2016-08-03 22:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:05:13]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-08-04 17:41:44]

lgtm

[bungeman-chromium, 2016-08-04 20:15:39]

bungeman@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[bungeman-chromium, 2016-08-04 20:15:40]

nyquist or dtrainor: could you take a quick look at the 	chrome/browser/android/
part of this. I suppose it's pretty trivial, but wanted to make sure someone
there knows we're doing these sorts of refactors.

[nyquist, 2016-08-04 20:49:35]

chrome/browser/android lgtm

[bungeman-chromium, 2016-08-04 20:51:29]

The CQ bit was checked by bungeman@chromium.org

[bungeman-chromium, 2016-08-04 20:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2206263003/#ps60001
(title: "Ref when needed.")

[commit-bot: I haz the power, 2016-08-04 20:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 01:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 01:00:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bungeman-chromium, 2016-08-05 02:08:04]

The CQ bit was checked by bungeman@chromium.org

[commit-bot: I haz the power, 2016-08-05 02:08:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 03:41:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 03:43:49]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Skia is moving to returning smart pointers when creating an SkData.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Skia is moving to returning smart pointers when creating an SkData.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7eefc9a19b85a7bfb10162351a176868b6caeacf
Cr-Commit-Position: refs/heads/master@{#409985}
==========

[commit-bot: I haz the power, 2016-08-05 03:43:51]

Patchset 4 (id:??) landed as
https://crrev.com/7eefc9a19b85a7bfb10162351a176868b6caeacf
Cr-Commit-Position: refs/heads/master@{#409985}