chrome/browser/android/thumbnail/thumbnail_cache.cc - Issue 2206263003: Remove SK_SUPPORT_LEGACY_DATA_FACTORIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/thumbnail/thumbnail_cache.cc

Issue 2206263003: Remove SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ref when needed. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/thumbnail/thumbnail_cache.cc

diff --git a/chrome/browser/android/thumbnail/thumbnail_cache.cc b/chrome/browser/android/thumbnail/thumbnail_cache.cc

index 0996a9ee11d6ce808845c517e19efbab7674a22c..295d7fbf9e731628b8f8acff7b811be57c866759 100644

--- a/chrome/browser/android/thumbnail/thumbnail_cache.cc

+++ b/chrome/browser/android/thumbnail/thumbnail_cache.cc

@@ -569,7 +569,7 @@ void ThumbnailCache::CompressionTask(

encoded_size.height(),

kUnknown_SkColorType,

kUnpremul_SkAlphaType);

- sk_sp<SkData> etc1_pixel_data(SkData::NewUninitialized(encoded_bytes));

+ sk_sp<SkData> etc1_pixel_data(SkData::MakeUninitialized(encoded_bytes));

sk_sp<SkMallocPixelRef> etc1_pixel_ref(

SkMallocPixelRef::NewWithData(info, 0, NULL, etc1_pixel_data.get()));

@@ -685,7 +685,7 @@ bool ReadFromFile(base::File& file,

}

int data_size = etc1_get_encoded_data_size(raw_width, raw_height);

- sk_sp<SkData> etc1_pixel_data(SkData::NewUninitialized(data_size));

+ sk_sp<SkData> etc1_pixel_data(SkData::MakeUninitialized(data_size));

int pixel_bytes_read = file.ReadAtCurrentPos(

reinterpret_cast<char*>(etc1_pixel_data->writable_data()),

« no previous file with comments | « cc/debug/picture_debug_util.cc ('k') | content/renderer/gpu/gpu_benchmarking_extension.cc » ('j') | no next file with comments »