Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2206183002: Move ErrorToString to runtime (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move ErrorToString to runtime BUG= Committed: https://crrev.com/2fc2bbdd4152a1194a3a11f4cb9ba4243eb9c2c6 Cr-Commit-Position: refs/heads/master@{#38295}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/mirrors.js View 3 chunks +1 line, -3 lines 0 comments Download
M src/js/messages.js View 2 chunks +0 lines, -17 lines 0 comments Download
M src/js/prologue.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
A src/runtime/runtime-error.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
Unfortunately we can't do %_Call(%error_to_string, ...). Added a runtime function instead.
4 years, 4 months ago (2016-08-03 08:52:04 UTC) #6
Yang
lgtm.
4 years, 4 months ago (2016-08-03 09:17:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206183002/20001
4 years, 4 months ago (2016-08-03 13:03:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 13:53:22 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:53:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fc2bbdd4152a1194a3a11f4cb9ba4243eb9c2c6
Cr-Commit-Position: refs/heads/master@{#38295}

Powered by Google App Engine
This is Rietveld 408576698