src/debug/mirrors.js - Issue 2206183002: Move ErrorToString to runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/mirrors.js

Issue 2206183002: Move ErrorToString to runtime (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/mirrors.js

diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js

index 84ea9abb0e06e5d9fca978d54a903358b290688a..41c14afd5d33cd7c4aaf7bd62a8d6b064c4d0678 100644

--- a/src/debug/mirrors.js

+++ b/src/debug/mirrors.js

@@ -8,7 +8,6 @@

// ----------------------------------------------------------------------------

// Imports

-var ErrorToString;

var GlobalArray = global.Array;

var IsNaN = global.isNaN;

var JSONStringify = global.JSON.stringify;

@@ -21,7 +20,6 @@ var SetIteratorNext;

var SetValues;

utils.Import(function(from) {

- ErrorToString = from.ErrorToString;

MakeError = from.MakeError;

MapEntries = from.MapEntries;

MapIteratorNext = from.MapIteratorNext;

@@ -1255,7 +1253,7 @@ ErrorMirror.prototype.toText = function() {

// Use the same text representation as in messages.js.

var text;

try {

- text = %_Call(ErrorToString, this.value_);

+ text = %ErrorToString(this.value_);

} catch (e) {

text = '#<Error>';

}

« no previous file with comments | « BUILD.gn ('k') | src/js/messages.js » ('j') | no next file with comments »