Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2206143003: Fix compiler complaints about uninit vars (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix compiler complaints about uninit vars BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206143003 Committed: https://skia.googlesource.com/skia/+/a5c357f2d4dfbdf0a590d44dcc87ad6e74f052b5

Patch Set 1 #

Patch Set 2 : Set to zero #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/core/SkColorSpaceXformOpts.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2059283002 Patch 80001

Messages

Total messages: 20 (13 generated)
msarett
Not really thrilled about this...
4 years, 4 months ago (2016-08-03 21:31:11 UTC) #8
mtklein
lgtm
4 years, 4 months ago (2016-08-03 21:37:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206143003/40001
4 years, 4 months ago (2016-08-03 21:37:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/5393)
4 years, 4 months ago (2016-08-03 22:04:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206143003/40001
4 years, 4 months ago (2016-08-03 22:05:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206143003/40001
4 years, 4 months ago (2016-08-03 22:45:39 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:46:36 UTC) #20
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/a5c357f2d4dfbdf0a590d44dcc87ad6e74f052b5

Powered by Google App Engine
This is Rietveld 408576698