Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2206083002: Generate default AP stream for strike out annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Generate default AP stream for strike out annotation. This patch generates a default AP stream for strike out annotation so that strike out annotations without AP stream can be displayed. Also, roll DEPS for testing/corpus to ddc1938 to test strike out annotations. BUG=62625 Committed: https://pdfium.googlesource.com/pdfium/+/0d8c2d120efe62d79d083f25b43aa814d0f24646

Patch Set 1 #

Total comments: 2

Patch Set 2 : Generate default AP stream for strike out annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
jaepark
The trybots are failing because DEPS is not rolled yet.
4 years, 4 months ago (2016-08-02 23:52:16 UTC) #6
Lei Zhang
looking good Can we send the corpus update CL out at the same time? I ...
4 years, 4 months ago (2016-08-03 00:00:22 UTC) #7
jaepark
Rolled DEPS for testing/corpus to ddc1938 to test strike out annotations. https://codereview.chromium.org/2206083002/diff/1/core/fpdfdoc/cpdf_annot.cpp File core/fpdfdoc/cpdf_annot.cpp (right): ...
4 years, 4 months ago (2016-08-03 00:28:01 UTC) #13
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 00:30:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206083002/20001
4 years, 4 months ago (2016-08-03 00:32:08 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:32:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0d8c2d120efe62d79d083f25b43aa814d0f2...

Powered by Google App Engine
This is Rietveld 408576698