Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2206001: Merge 48149 - Relanding 48042.... (Closed)

Created:
10 years, 7 months ago by oritm
Modified:
9 years, 3 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 48149 - Relanding 48042. I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled). Disabling app launcher and enabling apps by default on ChromeOS . BUG=3218 TEST=Open the new tab, the new new tab should be shown. Any installed app should be showing in there. Review URL: http://codereview.chromium.org/2149003 TBR=jcivelli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -69 lines) Patch
M chrome/browser/browser.cc View 2 chunks +4 lines, -23 lines 0 comments Download
M chrome/browser/defaults.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/defaults.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/shown_sections_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
oritm
10 years, 7 months ago (2010-05-25 21:46:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698