Relanding 48042...

Relanding 48042.

I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).

Disabling app launcher and enabling apps by default on ChromeOS .

BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
     app should be showing in there.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48149

[Aaron Boodman, 2010-05-25 00:10:54]

http://codereview.chromium.org/2149003/diff/17003/35001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2149003/diff/17003/35001#newcode1055
chrome/browser/browser.cc:1055: if
(command_line->HasSwitch(switches::kAppsPanel)) {
Now --apps-panel is unsupported on chrome os. Is that what you meant? (what is
the harm in having the switch available on chrome os?)

http://codereview.chromium.org/2149003/diff/17003/35013
File chrome/common/extensions/extension_manifests_unittest.cc (right):

http://codereview.chromium.org/2149003/diff/17003/35013#newcode79
chrome/common/extensions/extension_manifests_unittest.cc:79: // On ChromeOS,
apps are enabled by default.
How about wrapping the return in an #if (OS_CHROMEOS) instead? That way this
will break when we turn on apps for other platforms and we'll remember to remove
it.

[Jay Civelli, 2010-05-25 00:29:29]

http://codereview.chromium.org/2149003/diff/17003/35001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2149003/diff/17003/35001#newcode1055
chrome/browser/browser.cc:1055: if
(command_line->HasSwitch(switches::kAppsPanel)) {
On 2010/05/25 00:10:54, Aaron Boodman wrote:
> Now --apps-panel is unsupported on chrome os. Is that what you meant? (what is
> the harm in having the switch available on chrome os?)
Good point. We can keep --apps-panel working on ChromeOS.

http://codereview.chromium.org/2149003/diff/17003/35013
File chrome/common/extensions/extension_manifests_unittest.cc (right):

http://codereview.chromium.org/2149003/diff/17003/35013#newcode79
chrome/common/extensions/extension_manifests_unittest.cc:79: // On ChromeOS,
apps are enabled by default.
On 2010/05/25 00:10:54, Aaron Boodman wrote:
> How about wrapping the return in an #if (OS_CHROMEOS) instead? That way this
> will break when we turn on apps for other platforms and we'll remember to
remove
> it.

Done.

[Aaron Boodman, 2010-05-25 05:26:31]

LGTM