[WebAPKs] Do not request WebAPK update when Web Manifest scope did not change

[WebAPKs] Do not request WebAPK update when Web Manifest scope did not change

webapk_installer.cc sets the scope URL to a default if the Web Manifest scope
URL is empty. This CL sets the scope URL from the fetched Web Manifest to the
default if it is empty prior to comparing the scope URLs

BUG=624834
TEST=ManifestUpgradeDetectorTest.*

Committed: https://crrev.com/4739bb0eebd658ea5975c47da94e0d87e9c3d0c1
Cr-Commit-Position: refs/heads/master@{#412746}

[pkotwicz, 2016-08-04 01:57:09]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-08-04 01:57:09]

Xi can you please take a look?

This CL depends on:
- https://codereview.chromium.org/2199413003/
- https://codereview.chromium.org/2138973002/
- https://codereview.chromium.org/2206493002/

[Xi Han, 2016-08-05 14:42:13]

https://codereview.chromium.org/2205953006/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
(right):

https://codereview.chromium.org/2205953006/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java:58:
private static class Data {
Can we reuse the FetchedManifestData?

https://codereview.chromium.org/2205953006/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java:212:
* Test than an upgrade is requested when the Web Manifest is updated from using
a non-empty
than->that

[pkotwicz, 2016-08-17 03:18:20]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2016-08-17 03:18:56]

Xi can you please take another look?

[pkotwicz, 2016-08-17 03:18:56]

Xi can you please take another look?

[Xi Han, 2016-08-17 13:13:14]

lgtm

[pkotwicz, 2016-08-17 14:36:11]

Yaron for OWNERS

[Yaron, 2016-08-17 16:35:16]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2016-08-17 16:35:16]

lgtm

[pkotwicz, 2016-08-18 04:08:20]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-18 04:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2205953006/#ps60001
(title: "Merge branch 'master' into webapk_updater_images30")

[commit-bot: I haz the power, 2016-08-18 04:08:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 04:54:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-18 04:57:33]

Description was changed from

==========
[WebAPKs] Do not request WebAPK update when Web Manifest scope did not change

webapk_installer.cc sets the scope URL to a default if the Web Manifest scope
URL is empty. This CL sets the scope URL from the fetched Web Manifest to the
default if it is empty prior to comparing the scope URLs

BUG=624834
TEST=ManifestUpgradeDetectorTest.*
==========

to

==========
[WebAPKs] Do not request WebAPK update when Web Manifest scope did not change

webapk_installer.cc sets the scope URL to a default if the Web Manifest scope
URL is empty. This CL sets the scope URL from the fetched Web Manifest to the
default if it is empty prior to comparing the scope URLs

BUG=624834
TEST=ManifestUpgradeDetectorTest.*

Committed: https://crrev.com/4739bb0eebd658ea5975c47da94e0d87e9c3d0c1
Cr-Commit-Position: refs/heads/master@{#412746}
==========

[commit-bot: I haz the power, 2016-08-18 04:57:34]

Patchset 3 (id:??) landed as
https://crrev.com/4739bb0eebd658ea5975c47da94e0d87e9c3d0c1
Cr-Commit-Position: refs/heads/master@{#412746}