Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

Issue 2205953006: [WebAPKs] Do not request WebAPK update when Web Manifest scope did not change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_updater_images30 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
index bc15be819631876d8f7cf869701ad140b1c3526b..93168912c8d592c2841f162dcc94ec2293c218b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
@@ -13,6 +13,7 @@ import android.text.TextUtils;
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
+import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.tab.Tab;
/**
@@ -153,6 +154,10 @@ public class ManifestUpgradeDetector implements ManifestUpgradeDetectorFetcher.C
mFetcher.destroy();
mFetcher = null;
+ if (TextUtils.isEmpty(scopeUrl)) {
+ scopeUrl = ShortcutHelper.getScopeFromUrl(startUrl);
+ }
+
FetchedManifestData fetchedData = new FetchedManifestData();
fetchedData.startUrl = startUrl;
fetchedData.scopeUrl = scopeUrl;
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698