Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Issue 2205933002: Add JSON parser to Source/platform (Closed)

Created:
4 years, 4 months ago by iclelland
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add JSON parser to Source/platform This is based on the inspector protocol parser, with a few changes: - Reads a WTF::String (either 8 or 16-bit) - Outputs blink::JSONValues - Uses RefPtr<>s for compatibility with blink::JSONValue, rather than std::unique_ptr<> These changes bring the parser almost exactly to the state that the inspector parser was in, in Feb 2016, except for not supporting the non-standard "\x" escape character. BUG=

Patch Set 1 #

Patch Set 2 : Switch to unique_ptr version of JSONValue classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -153 lines) Patch
A + third_party/WebKit/Source/platform/JSONParser.h View 1 1 chunk +10 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/platform/JSONParser.cpp View 1 18 chunks +64 lines, -44 lines 0 comments Download
A + third_party/WebKit/Source/platform/JSONParserTest.cpp View 1 17 chunks +100 lines, -102 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (8 generated)
iclelland
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-02 17:47:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205933002/1
4 years, 4 months ago (2016-08-02 17:48:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-02 19:58:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-08-02 19:58:26 UTC) #4
iclelland
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-04 14:45:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205933002/20001
4 years, 4 months ago (2016-08-04 14:45:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-04 15:36:16 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:36:17 UTC) #8
Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698