Make blink::JSONValue (and subclasses) use unique_ptr rather than RefPtrs.

Make blink::JSONValue (and subclasses) use unique_ptr rather than RefPtrs.

Some groundwork for this change was started back in February, but the transition was never actually made. (See https://crrev.com/ffa7f6f)

BUG=

[iclelland, 2016-08-04 14:34:34]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 14:35:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2016-08-04 14:51:15]

Description was changed from

==========
Make blink::JSONValue (and subclasses) use unique_ptr rather than RefPtrs.

BUG=
==========

to

==========
Make blink::JSONValue (and subclasses) use unique_ptr rather than RefPtrs.

Some groundwork for this change was started back in February, but the transition
was never actually made. (See https://crrev.com/ffa7f6f)

BUG=
==========

[iclelland, 2016-08-04 14:51:15]

iclelland@chromium.org changed reviewers:
+ jbroman@chromium.org

[iclelland, 2016-08-04 14:53:32]

+r jbroman -- Can you PTAL? There's a lot of std::move()ing going on, and I want
to make sure that I've done it all correctly.

Thanks!

[jbroman, 2016-08-04 15:17:31]

lgtm

If there's a relevant bug for this work, please update the BUG= line.

https://codereview.chromium.org/2204383003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/JSONValues.h (right):

https://codereview.chromium.org/2204383003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/JSONValues.h:58:
WTF_MAKE_NONCOPYABLE(JSONValue);
You may also want USING_FAST_MALLOC(JSONValue), as RefCounted<T> are allocated
with partition alloc by default, whereas this moves it to the malloc allocator.

https://codereview.chromium.org/2204383003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp (right):

https://codereview.chromium.org/2204383003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:844:
std::unique_ptr<JSONArray> LoggingCanvas::log()
nit: All of the existing call sites seem to stop drawing to the canvas at this
point; do we actually need to create a new log, or could we just "return
std::move(m_log);" with a comment that the canvas cannot be used after this
point? I don't feel strongly.

super-nit: If we do want this logic, I personally find it somewhat cleaner to
avoid std::swap (so that "originalLog" only ever contains the original log).
WDYT?

std::unique_ptr<JSONArray> originalLog = std::move(m_log);
m_log = JSONArray::create();
return originalLog;

[commit-bot: I haz the power, 2016-08-04 16:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 16:03:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)