Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2205903004: GN: get echo-headers sources via exec_script (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: get echo-headers sources via exec_script exec_script runs every time gn does, which is explicitly on every one of our bot runs. That should be enough to obviate the .git/logs/HEAD hack. Easiest way to do this was to swap around find.py's argument order to allow multiple search directories. This is the root of all the .gyp changes. This moves the blacklist into BUILD.gn, which I think is nice. It expands it a little as we're now searching recursively, into include/gpu/vk which we can't include safely without the Vulkan SDK. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205903004 Committed: https://skia.googlesource.com/skia/+/ada5a44f3bdac10a8a0c53b34f5add7aea9fdbb0

Patch Set 1 #

Patch Set 2 : fmt #

Patch Set 3 : still needed for Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M BUILD.gn View 1 2 3 chunks +16 lines, -4 lines 0 comments Download
M gn/echo_headers.py View 1 chunk +2 lines, -14 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/find.py View 1 chunk +10 lines, -9 lines 0 comments Download
M gyp/fuzz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/gputest.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/harfbuzz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/icu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/nanomsg.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/sfntly.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skiaserve.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/viewer.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 20:46:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205903004/20001
4 years, 4 months ago (2016-08-02 20:46:47 UTC) #8
jcgregorio
lgtm
4 years, 4 months ago (2016-08-02 20:49:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-GN-Trybot/builds/92)
4 years, 4 months ago (2016-08-02 20:52:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205903004/40001
4 years, 4 months ago (2016-08-02 21:03:50 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 21:28:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ada5a44f3bdac10a8a0c53b34f5add7aea9fdbb0

Powered by Google App Engine
This is Rietveld 408576698