gyp/icu.gyp - Issue 2205903004: GN: get echo-headers sources via exec_script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/icu.gyp

Issue 2205903004: GN: get echo-headers sources via exec_script (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: still needed for Mac Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/icu.gyp

diff --git a/gyp/icu.gyp b/gyp/icu.gyp

index 4a985032c26d61b2145ef092b2b838626d4a11de..f1a89c798e67fa4248db6f446339ced26392c028 100644

--- a/gyp/icu.gyp

+++ b/gyp/icu.gyp

@@ -15,7 +15,7 @@

'target_name': 'icuuc',

'type': '<(component)',

'sources': [

- '<!@(python find.py ../third_party/externals/icu/source/common "*.c*")'

+ '<!@(python find.py "*.c*" ../third_party/externals/icu/source/common)'

'defines': [

'U_COMMON_IMPLEMENTATION',

« no previous file with comments | « gyp/harfbuzz.gyp ('k') | gyp/nanomsg.gyp » ('j') | no next file with comments »