Reland [builtins] implement Array.prototype.includes in TurboFan

Reland [builtins] implement Array.prototype.includes in TurboFan

BUG=v8:5162
R=bmeurer@chromium.org, cbruni@chromium.org

Committed: https://crrev.com/0c76b0ae850027006d5ec0d92449e449d996d3bb
Cr-Commit-Position: refs/heads/master@{#38266}

[Camillo Bruni, 2016-08-02 14:18:09]

lgtm

[caitp, 2016-08-02 14:18:24]

PTAL --- Could someone run a try on client.v8.ports / gyp_release_arm?

[Michael Achenbach, 2016-08-02 14:39:44]

We don't have a trybot for this. Just land and see...

[caitp, 2016-08-02 14:40:16]

The CQ bit was checked by caitp@igalia.com

[commit-bot: I haz the power, 2016-08-02 14:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 14:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 14:47:58]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20778)

[caitp, 2016-08-02 14:49:09]

On 2016/08/02 14:47:58, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20778)

Well, I guess we'll have to wait a while to try that out :)

[Benedikt Meurer, 2016-08-03 03:25:09]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-08-03 03:25:10]

lgtm

[commit-bot: I haz the power, 2016-08-03 03:25:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 03:27:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 03:27:52]

Description was changed from

==========
Reland [builtins] implement Array.prototype.includes in TurboFan

BUG=v8:5162
R=bmeurer@chromium.org, cbruni@chromium.org
==========

to

==========
Reland [builtins] implement Array.prototype.includes in TurboFan

BUG=v8:5162
R=bmeurer@chromium.org, cbruni@chromium.org

Committed: https://crrev.com/0c76b0ae850027006d5ec0d92449e449d996d3bb
Cr-Commit-Position: refs/heads/master@{#38266}
==========

[commit-bot: I haz the power, 2016-08-03 03:27:54]

Patchset 2 (id:??) landed as
https://crrev.com/0c76b0ae850027006d5ec0d92449e449d996d3bb
Cr-Commit-Position: refs/heads/master@{#38266}

[Igor Sheludko, 2016-09-22 12:05:59]

ishell@chromium.org changed reviewers:
+ ishell@chromium.org

[Igor Sheludko, 2016-09-22 12:06:00]

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:518: Node* b_instance_type = LoadInstanceType(b_map);
DBC: this should be a LoadMapInstanceType().

[Igor Sheludko, 2016-09-23 11:00:03]

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:474: void
CodeStubAssembler::BranchIfSameValueZero(Node* a, Node* b, Node* context,
Why did you add this function if it's not used? Is it going to be used in the
near future?

[caitp, 2016-09-23 11:26:49]

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:474: void
CodeStubAssembler::BranchIfSameValueZero(Node* a, Node* b, Node* context,
On 2016/09/23 11:00:03, Igor Sheludko wrote:
> Why did you add this function if it's not used? Is it going to be used in the
> near future?

It was originally used in a simpler version of the CL, but I left it thinking it
might be worthwhile to move Runtime_SameValueZero to a stub. Hasn't happened
yet, and I wouldn't be offended if we opted to delete it if it's still dead code

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:518: Node* b_instance_type = LoadInstanceType(b_map);
On 2016/09/22 12:06:00, Igor Sheludko wrote:
> DBC: this should be a LoadMapInstanceType().

This had been fixed in a followup (https://codereview.chromium.org/2207903002)
--- it probably means the test coverage for A.p.includes isn't good enough, but
at least clusterfuzz caught it

[Igor Sheludko, 2016-09-23 11:30:56]

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2205883003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:518: Node* b_instance_type = LoadInstanceType(b_map);
On 2016/09/23 11:26:49, caitp wrote:
> On 2016/09/22 12:06:00, Igor Sheludko wrote:
> > DBC: this should be a LoadMapInstanceType().
> 
> This had been fixed in a followup (https://codereview.chromium.org/2207903002)
> --- it probably means the test coverage for A.p.includes isn't good enough,
but
> at least clusterfuzz caught it

This code is sill in the tree although the BranchIfSameValueZero() function is
not used.