Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2207903002: [builtins] fix mapcheck in Array.includes fast-case when searching for String (Closed)

Created:
4 years, 4 months ago by caitp
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] fix mapcheck in Array.includes fast-case when searching for String Use LoadInstanceType() rather than LoadMapInstanceType(), as this part of the code is operating on a JS-accessible HeapObject rather than a Map. BUG=chromium:633883, v8:5162 R=mstarzinger@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/c4ee3d94740f865f485173f4a3a194b6973f2d34 Cr-Commit-Position: refs/heads/master@{#38297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/builtins/builtins-array.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es7/regress/regress-633883.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
caitp
PTAL I have no idea why I was not able to reproduce this on an ...
4 years, 4 months ago (2016-08-03 12:58:50 UTC) #1
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-03 13:31:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207903002/1
4 years, 4 months ago (2016-08-03 14:25:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 14:26:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:27:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4ee3d94740f865f485173f4a3a194b6973f2d34
Cr-Commit-Position: refs/heads/master@{#38297}

Powered by Google App Engine
This is Rietveld 408576698