Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 2205743002: Add non-null types list to StrongModeOptions (Closed) Base URL: https://github.com/dart-lang/sdk@master
Patch Set: Use annotation instead of prefix for 'failing test' Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index e7bd28f0daa8d084cb24e56e6b84ef443fd24f82..354c39b0d71b3d0d956ee7ca6c4eb74e4d640bd5 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -1303,6 +1303,12 @@ class AnalysisOptionsImpl implements AnalysisOptions {
*/
bool implicitCasts = true;
+ /**
+ * A list of non-nullable type names (e.g., 'int', 'bool', etc.).
+ */
+ List<String> nonnullableTypes = NONNULLABLE_TYPES;
Brian Wilkerson 2016/08/02 15:04:36 Is it the case that the type names in this list wi
stanm 2016/08/02 16:56:05 Good point! As John suggested, I will add the pref
+ static const List<String> NONNULLABLE_TYPES = const <String>[];
Brian Wilkerson 2016/08/02 15:04:36 nit: we auto-format and auto-sort our source files
stanm 2016/08/02 16:56:05 Thanks! I'm already using `dartfmt` for formatting
+
@override
bool finerGrainedInvalidation = false;
@@ -1350,6 +1356,7 @@ class AnalysisOptionsImpl implements AnalysisOptions {
if (options is AnalysisOptionsImpl) {
strongModeHints = options.strongModeHints;
implicitCasts = options.implicitCasts;
+ nonnullableTypes = options.nonnullableTypes;
implicitDynamic = options.implicitDynamic;
}
trackCacheDependencies = options.trackCacheDependencies;

Powered by Google App Engine
This is Rietveld 408576698