Add non-null types list to StrongModeOptions

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.engine;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 1285 matching lines @@
   bool trackCacheDependencies = true;
 
   /**
    * A flag indicating whether implicit casts are allowed in [strongMode]
    * (they are always allowed in Dart 1.0 mode).
    *
    * This option is experimental and subject to change.
    */
   bool implicitCasts = true;
 
+  /**
+   * A list of non-nullable type names (e.g., 'int', 'bool', etc.).
+   */
+  List<String> nonnullableTypes = NONNULLABLE_TYPES;

[Brian Wilkerson, 2016/08/02 15:04:36]

Is it the case that the type names in this list will only match types when they
are defined in a `dart:` library? If so, it would be good to document that
constraint.

[stanm, 2016/08/02 16:56:05]

Good point! As John suggested, I will add the prefix as part of the element in
`nonnullableTypes`.

+  static const List<String> NONNULLABLE_TYPES = const <String>[];

[Brian Wilkerson, 2016/08/02 15:04:36]

nit: we auto-format and auto-sort our source files (so this constant would be
moved after the other static fields)

[stanm, 2016/08/02 16:56:05]

Thanks! I'm already using `dartfmt` for formatting, but is there anything I can
use for auto-sorting? And if I understand correctly, this constant needs to go
after `bool implicitDynamic = true;`.

+
   @override
   bool finerGrainedInvalidation = false;
 
   /**
    * A flag indicating whether implicit dynamic type is allowed, on by default.
    *
    * This flag can be used without necessarily enabling [strongMode], but it is
    * designed with strong mode's type inference in mind. Without type inference,
    * it will raise many errors. Also it does not provide type safety without
    * strong mode.
@@ skipping 27 matching lines @@
     hint = options.hint;
     incremental = options.incremental;
     incrementalApi = options.incrementalApi;
     incrementalValidation = options.incrementalValidation;
     lint = options.lint;
     preserveComments = options.preserveComments;
     strongMode = options.strongMode;
     if (options is AnalysisOptionsImpl) {
       strongModeHints = options.strongModeHints;
       implicitCasts = options.implicitCasts;
+      nonnullableTypes = options.nonnullableTypes;
       implicitDynamic = options.implicitDynamic;
     }
     trackCacheDependencies = options.trackCacheDependencies;
     finerGrainedInvalidation = options.finerGrainedInvalidation;
   }
 
   bool get analyzeFunctionBodies {
     if (identical(analyzeFunctionBodiesPredicate, _analyzeAllFunctionBodies)) {
       return true;
     } else if (identical(
@@ skipping 1340 matching lines @@
    * The data that was created from the source.
    */
   final E data;
 
   /**
    * Initialize a newly created holder to associate the given [data] with the
    * given [modificationTime].
    */
   TimestampedData(this.modificationTime, this.data);
 }