Add non-null types list to StrongModeOptions

Add non-null types list to StrongModeOptions

There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

Based on https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d257617d63bee .

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/6cafcbb87a7b15e7a55a3714b80c736890323461

[stanm, 2016-08-02 00:37:07]

stanm@google.com changed reviewers:
+ brianwilkerson@google.com, jmesserly@google.com

[Brian Wilkerson, 2016-08-02 15:04:36]

lgtm

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:1309: List<String> nonnullableTypes =
NONNULLABLE_TYPES;
Is it the case that the type names in this list will only match types when they
are defined in a `dart:` library? If so, it would be good to document that
constraint.

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:1310: static const List<String>
NONNULLABLE_TYPES = const <String>[];
nit: we auto-format and auto-sort our source files (so this constant would be
moved after the other static fields)

[Jennifer Messerly, 2016-08-02 16:18:51]

lgtm

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/non_null_checker_test.dart (right):

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/non_null_checker_test.dart:56:
check(nonnullableTypes: <String>['int']);
to build on Brian's comment, consider qualifying it with an import URI, e.g.
'dart:core,int'

[Brian Wilkerson, 2016-08-02 16:25:18]

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/non_null_checker_test.dart (right):

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/non_null_checker_test.dart:56:
check(nonnullableTypes: <String>['int']);
Unless this is intended to be a general purpose mechanism (I want to be able to
declare that my 'Point' class can never be null) that seems like overkill. I was
guessing that this is just to allow the translator to not have to wrap instances
of classes that could otherwise be converted to Java primitive types. But I
probably don't have the full picture, so your call.

[stanm, 2016-08-02 16:55:30]

Description was changed from

==========
Add non-null types list to StrongModeOptions

There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

BUG=
==========

to

==========
Add non-null types list to StrongModeOptions

There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

Based on
https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d...
.

BUG=
==========

[stanm, 2016-08-02 16:56:05]

Thanks for the reviews! I will address the comments by changing the code before
landing.

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:1309: List<String> nonnullableTypes =
NONNULLABLE_TYPES;
On 2016/08/02 15:04:36, Brian Wilkerson wrote:
> Is it the case that the type names in this list will only match types when
they
> are defined in a `dart:` library? If so, it would be good to document that
> constraint.

Good point! As John suggested, I will add the prefix as part of the element in
`nonnullableTypes`.

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:1310: static const List<String>
NONNULLABLE_TYPES = const <String>[];
On 2016/08/02 15:04:36, Brian Wilkerson wrote:
> nit: we auto-format and auto-sort our source files (so this constant would be
> moved after the other static fields)

Thanks! I'm already using `dartfmt` for formatting, but is there anything I can
use for auto-sorting? And if I understand correctly, this constant needs to go
after `bool implicitDynamic = true;`.

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/non_null_checker_test.dart (right):

https://codereview.chromium.org/2205743002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/non_null_checker_test.dart:56:
check(nonnullableTypes: <String>['int']);
On 2016/08/02 16:25:18, Brian Wilkerson wrote:
> Unless this is intended to be a general purpose mechanism (I want to be able
to
> declare that my 'Point' class can never be null) that seems like overkill. I
was
> guessing that this is just to allow the translator to not have to wrap
instances
> of classes that could otherwise be converted to Java primitive types. But I
> probably don't have the full picture, so your call.

I agree it's a bit of an overkill, but it actually makes implementing this
experimental feature easier (after adding the import URI, as John mentioned),
since then I can directly do a `contains` check whenever I need to handle
non-nullable types in a special way.

Also, I don't plan to make this user-visible: the actual compiler option will be
something like '--non-nullable-primitives' and will enable a preset collection
of non-nullable classes.

Also, I will add to the commit message that this CL is based on previous work
from Vijay:
https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d...

(ironically, this is the commit that undoes it : )

[stanm, 2016-08-02 20:38:17]

Description was changed from

==========
Add non-null types list to StrongModeOptions

There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

Based on
https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d...
.

BUG=
==========

to

==========
Add non-null types list to StrongModeOptions

There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

Based on
https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d...
.

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6cafcbb87a7b15e7a55a3714b80c736890323461
==========

[stanm, 2016-08-02 20:38:18]

Committed patchset #3 (id:40001) manually as
6cafcbb87a7b15e7a55a3714b80c736890323461 (presubmit successful).