Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issue 2205693004: Rename and repurpose ComponentInstallerTraits::CanAutoUpdate. (Closed)

Created:
4 years, 4 months ago by Sorin Jianu
Modified:
4 years, 4 months ago
Reviewers:
waffles
CC:
chromium-reviews, pam+watch_chromium.org, chasej+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cus-gp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename and repurpose ComponentInstallerTraits::CanAutoUpdate. This is a mechanical change. It declares the components using the DefaultComponentInstaller as not supporting GP. BUG=624128 Committed: https://crrev.com/3574ef96bd3a663127dac1b5b0ad3730112d43b4 Cr-Commit-Position: refs/heads/master@{#409537}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -49 lines) Patch
M chrome/browser/component_updater/caps_installer_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/file_type_policies_component_installer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/file_type_policies_component_installer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/origin_trials_component_installer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/origin_trials_component_installer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/subresource_filter_component_installer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/subresource_filter_component_installer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/supervised_user_whitelist_installer.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M components/component_updater/default_component_installer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/component_updater/default_component_installer.cc View 1 1 chunk +17 lines, -19 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Sorin Jianu
4 years, 4 months ago (2016-08-02 23:24:49 UTC) #9
Sorin Jianu
4 years, 4 months ago (2016-08-03 00:40:14 UTC) #12
waffles
lgtm
4 years, 4 months ago (2016-08-03 01:49:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205693004/20001
4 years, 4 months ago (2016-08-03 16:41:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 16:46:23 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:49:43 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3574ef96bd3a663127dac1b5b0ad3730112d43b4
Cr-Commit-Position: refs/heads/master@{#409537}

Powered by Google App Engine
This is Rietveld 408576698