chrome/browser/component_updater/pepper_flash_component_installer.cc - Issue 2205693004: Rename and repurpose ComponentInstallerTraits::CanAutoUpdate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pepper_flash_component_installer.cc

Issue 2205693004: Rename and repurpose ComponentInstallerTraits::CanAutoUpdate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cus-gp

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/origin_trials_component_installer.cc ('k') | chrome/browser/component_updater/sth_set_component_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pepper_flash_component_installer.cc

diff --git a/chrome/browser/component_updater/pepper_flash_component_installer.cc b/chrome/browser/component_updater/pepper_flash_component_installer.cc

index 75c33e059649a84114c5fb803205ae04d6640663..4bfde05c5bb433add658535041b92fa4682e3c40 100644

--- a/chrome/browser/component_updater/pepper_flash_component_installer.cc

+++ b/chrome/browser/component_updater/pepper_flash_component_installer.cc

@@ -175,7 +175,7 @@ class FlashComponentInstallerTraits : public ComponentInstallerTraits {

private:

// The following methods override ComponentInstallerTraits.

- bool CanAutoUpdate() const override;

+ bool SupportsGroupPolicyEnabledComponentUpdates() const override;

bool RequiresNetworkEncryption() const override;

bool OnCustomInstall(const base::DictionaryValue& manifest,

const base::FilePath& install_dir) override;

@@ -195,8 +195,9 @@ class FlashComponentInstallerTraits : public ComponentInstallerTraits {

FlashComponentInstallerTraits::FlashComponentInstallerTraits() {}

-bool FlashComponentInstallerTraits::CanAutoUpdate() const {

- return true;

+bool FlashComponentInstallerTraits::SupportsGroupPolicyEnabledComponentUpdates()

+ const {

+ return false;

}

bool FlashComponentInstallerTraits::RequiresNetworkEncryption() const {