Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: device/bluetooth/bluetooth_device_android.h

Issue 2205693003: bluetooth: Replace old advertised uuids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Fix mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device_android.h
diff --git a/device/bluetooth/bluetooth_device_android.h b/device/bluetooth/bluetooth_device_android.h
index 89ea49d6231f5c166afd1e3d0c59cbe2e3996683..d4d9ca674419f261c9954395b30c0bfbe0477a82 100644
--- a/device/bluetooth/bluetooth_device_android.h
+++ b/device/bluetooth/bluetooth_device_android.h
@@ -49,10 +49,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceAndroid final
return static_cast<BluetoothAdapterAndroid*>(adapter_);
}
- // Updates cached copy of advertised UUIDs discovered during a scan.
- // Returns true if new UUIDs differed from cached values.
- bool UpdateAdvertisedUUIDs(
- jobject advertised_uuids); // Java Type: List<ParcelUuid>
+ // Replaces cached copy of advertised UUIDs discovered during a scan.
+ void UpdateAdvertisedUUIDs(
scheib 2016/08/05 18:49:31 Why drop the bool return value? We shouldn't re-no
ortuno 2016/08/05 23:00:17 We will notify for each advertisement. So the bool
+ jobjectArray advertised_uuids); // Java Type: String[]
// BluetoothDevice:
uint32_t GetBluetoothClass() const override;
@@ -68,7 +67,6 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceAndroid final
bool IsGattConnected() const override;
bool IsConnectable() const override;
bool IsConnecting() const override;
- UUIDList GetUUIDs() const override;
int16_t GetInquiryRSSI() const override;
int16_t GetInquiryTxPower() const override;
bool ExpectingPinCode() const override;

Powered by Google App Engine
This is Rietveld 408576698