bluetooth: Replace old advertised uuids

device/bluetooth/bluetooth_device_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_ANDROID_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_ANDROID_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 31 matching lines @@
   static bool RegisterJNI(JNIEnv* env);
 
   // Returns the associated ChromeBluetoothDevice Java object.
   base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
 
   // Get owning BluetoothAdapter cast to BluetoothAdapterAndroid.
   BluetoothAdapterAndroid* GetAndroidAdapter() {
     return static_cast<BluetoothAdapterAndroid*>(adapter_);
   }
 
-  // Updates cached copy of advertised UUIDs discovered during a scan.
-  // Returns true if new UUIDs differed from cached values.
-  bool UpdateAdvertisedUUIDs(
-      jobject advertised_uuids);  // Java Type: List<ParcelUuid>
+  // Replaces cached copy of advertised UUIDs discovered during a scan.
+  void UpdateAdvertisedUUIDs(

[scheib, 2016/08/05 18:49:31]

Why drop the bool return value? We shouldn't re-notify if UUIDs haven't changed.

[ortuno, 2016/08/05 23:00:17]

We will notify for each advertisement. So the bool returned by this doesn't help
anymore.

+      jobjectArray advertised_uuids);  // Java Type: String[]
 
   // BluetoothDevice:
   uint32_t GetBluetoothClass() const override;
   std::string GetAddress() const override;
   VendorIDSource GetVendorIDSource() const override;
   uint16_t GetVendorID() const override;
   uint16_t GetProductID() const override;
   uint16_t GetDeviceID() const override;
   uint16_t GetAppearance() const override;
   base::Optional<std::string> GetName() const override;
   bool IsPaired() const override;
   bool IsConnected() const override;
   bool IsGattConnected() const override;
   bool IsConnectable() const override;
   bool IsConnecting() const override;
-  UUIDList GetUUIDs() const override;
   int16_t GetInquiryRSSI() const override;
   int16_t GetInquiryTxPower() const override;
   bool ExpectingPinCode() const override;
   bool ExpectingPasskey() const override;
   bool ExpectingConfirmation() const override;
   void GetConnectionInfo(const ConnectionInfoCallback& callback) override;
   void Connect(device::BluetoothDevice::PairingDelegate* pairing_delegate,
                const base::Closure& callback,
                const ConnectErrorCallback& error_callback) override;
   void SetPinCode(const std::string& pincode) override;
@@ skipping 48 matching lines @@
   base::android::ScopedJavaGlobalRef<jobject> j_device_;
 
   bool gatt_connected_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothDeviceAndroid);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_ANDROID_H_