Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2205573004: Fix Jbig2 document context creation by checking proper pointer (Closed)

Created:
4 years, 4 months ago by Wei Li
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix Jbig2 document context creation by checking proper pointer The pointer a unique_ptr contains should be checked instead of the pointer of the unique_ptr itself. BUG=chromium:631912 Committed: https://pdfium.googlesource.com/pdfium/+/6faf9f9508b858e27fde9a7f75ff6962048326ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + core/fxcodec/codec/fx_codec_embeddertest.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/bug_631912.pdf View Binary file 0 comments Download

Messages

Total messages: 11 (7 generated)
Wei Li
pls review, thanks
4 years, 4 months ago (2016-08-02 18:31:01 UTC) #6
dsinclair
lgtm
4 years, 4 months ago (2016-08-02 18:33:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205573004/1
4 years, 4 months ago (2016-08-02 18:33:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:34:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6faf9f9508b858e27fde9a7f75ff69620483...

Powered by Google App Engine
This is Rietveld 408576698