core/fxcodec/codec/fx_codec_jbig.cpp - Issue 2205573004: Fix Jbig2 document context creation by checking proper pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/fx_codec_jbig.cpp

Issue 2205573004: Fix Jbig2 document context creation by checking proper pointer (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcodec/codec/fx_codec_jbig.cpp

diff --git a/core/fxcodec/codec/fx_codec_jbig.cpp b/core/fxcodec/codec/fx_codec_jbig.cpp

index adc57fd1ad42a114659b334d630719b05ec542cb..7713ca3ecbe67d39e2b09e14ab2f5f85967bc27e 100644

--- a/core/fxcodec/codec/fx_codec_jbig.cpp

+++ b/core/fxcodec/codec/fx_codec_jbig.cpp

@@ -20,7 +20,7 @@ JBig2_DocumentContext::~JBig2_DocumentContext() {}

JBig2_DocumentContext* GetJBig2DocumentContext(

std::unique_ptr<JBig2_DocumentContext>* pContextHolder) {

- if (!pContextHolder)

+ if (!pContextHolder->get())

pContextHolder->reset(new JBig2_DocumentContext());

return pContextHolder->get();

}

« no previous file with comments | « core/fxcodec/codec/fx_codec_embeddertest.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »