Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2205563002: Fix newTabPageShareProces() in chrome.processes API browsertests (Closed)

Created:
4 years, 4 months ago by afakhry
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix newTabPageShareProces() in chrome.processes API browsertests The test used to fail in --site-per-process BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process Committed: https://crrev.com/7051dd3f77013b0e0bcc7447cdbcfe38aeb66a20 Cr-Commit-Position: refs/heads/master@{#409329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/test/data/extensions/api_test/processes/api/test.js View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
afakhry
Charlie, as agreed last week, I'll start trying to get these tests to work without ...
4 years, 4 months ago (2016-08-02 00:26:01 UTC) #6
Charlie Reis
Thanks! Just an off by one here? Let's give it a try. LGTM.
4 years, 4 months ago (2016-08-02 20:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205563002/1
4 years, 4 months ago (2016-08-02 21:22:46 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 21:36:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7051dd3f77013b0e0bcc7447cdbcfe38aeb66a20
Cr-Commit-Position: refs/heads/master@{#409329}

Powered by Google App Engine
This is Rietveld 408576698