Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/test/data/extensions/api_test/processes/api/test.js

Issue 2205563002: Fix newTabPageShareProces() in chrome.processes API browsertests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/processes/api/test.js
diff --git a/chrome/test/data/extensions/api_test/processes/api/test.js b/chrome/test/data/extensions/api_test/processes/api/test.js
index ee165bbaf195c20734c676d76eb2678b86e8693f..7a9be96d5c8cc7148dc1f1c2a757bfb5b0060ada 100644
--- a/chrome/test/data/extensions/api_test/processes/api/test.js
+++ b/chrome/test/data/extensions/api_test/processes/api/test.js
@@ -107,15 +107,13 @@ chrome.test.runTests([
// Once the NTP finishes loading, create another one. This ensures
// both NTPs end up in the same process.
- if (changedTabId == tabs[3].id) {
+ if (changedTabId == tabs[3].id)
createTab(4, "chrome://newtab/");
- }
}
// Once all tabs are done loading, continue with the next test.
- if (completedCount == 4) {
+ if (completedCount == 5)
onUpdatedCompleted();
- }
}
);
@@ -169,9 +167,6 @@ chrome.test.runTests([
}));
},
- // DISABLED: crbug.com/594318
- // Fails in --site-per-process
- /*
function newTabPagesShareProcess() {
getProcessId(tabs[3].id, pass(function(pid3) {
getProcessId(tabs[4].id, pass(function(pid4) {
@@ -180,7 +175,6 @@ chrome.test.runTests([
}));
}));
},
- */
function idsInUpdateEvent() {
listenOnce(chrome.processes.onUpdated, function(processes) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698