Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 220553002: Revert of Introduce an intra-priority level sorting value - Chromium Side (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Introduce an intra-priority level sorting value - Chromium Side (https://codereview.chromium.org/146333004/) Reason for revert: Broke a layout test, http/tests/loading/promote-img-in-viewport-priority.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=http%2Ftests%2Floading%2Fpromote-img-in-viewport-priority.html Original issue's description: > This CL adds an intra-priority level sorting value for finer grained control of resource loading. The blink side of this patch sorts visible images by estimated on screen real-estate, preferring to download images with more visual impact first. Ie. On a page with a large banner, and dozens of small icons, the large banner will most likely be scheduled ahead of the others. > > In the future, we can also use this to experiment with other signals, ie. prioritize by distance to viewport. > > This needs https://codereview.chromium.org/153983004/ to land first. > > In our tests, this was a nice win on speed-index for desktop, with a gain of about ~2-3%. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260665 TBR=simonjam@chromium.org,darin@chromium.org,cevans@chromium.org,simonhatch@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -194 lines) Patch
M content/browser/loader/resource_scheduler.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 14 chunks +72 lines, -124 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 2 chunks +2 lines, -26 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M content/child/web_url_loader_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/WebFrameTestProxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/child/resource_loader_bridge.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Created Revert of Introduce an intra-priority level sorting value - Chromium Side
6 years, 8 months ago (2014-04-01 04:09:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/220553002/1
6 years, 8 months ago (2014-04-01 04:10:15 UTC) #2
commit-bot: I haz the power
Change committed as 260772
6 years, 8 months ago (2014-04-01 04:11:02 UTC) #3
shatch
On 2014/04/01 04:11:02, I haz the power (commit-bot) wrote: > Change committed as 260772 So ...
6 years, 8 months ago (2014-04-01 17:58:29 UTC) #4
tkent
On 2014/04/01 17:58:29, shatch wrote: > On 2014/04/01 04:11:02, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-02 00:13:21 UTC) #5
shatch
6 years, 8 months ago (2014-04-02 17:53:02 UTC) #6
Message was sent while issue was closed.
On 2014/04/02 00:13:21, tkent wrote:
> On 2014/04/01 17:58:29, shatch wrote:
> > On 2014/04/01 04:11:02, I haz the power (commit-bot) wrote:
> > > Change committed as 260772
> > 
> > So think I need to land a change to the
> > http/tests/loading/promote-img-in-viewport-priority.html to account for the
> new
> > output. Looks like the proper way to do this is to:
> > 
> > 1. Make the change in blink.
> > 2. Modify src/webkit/tools/layout_tests/test_expecations.txt to expect the
> > failure until the next blink roll.
> > 
> > Is that right?
> 
> In this procedure, Blink bots will fail between 1 and 2.
> 
> I recommend:
>   1. Update promote-img-in-viewport-priority.html and
> LayoutTests/TestExpectation so that the test failure is expected.
>   2. Wait for a Blink roll.
>   3. Land the Chromium change again
>   4. Revert LayoutTests/TestExpectation

Awesome, thanks for the clarification!

Powered by Google App Engine
This is Rietveld 408576698