Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: content/browser/loader/resource_scheduler_unittest.cc

Issue 220553002: Revert of Introduce an intra-priority level sorting value - Chromium Side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/child/resource_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_scheduler_unittest.cc
diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc
index e677f8f12d8c6d7297c4a081b29764e53f032ee5..912c2bb37e819f9e68091a2e96ba50ba3994b8ae 100644
--- a/content/browser/loader/resource_scheduler_unittest.cc
+++ b/content/browser/loader/resource_scheduler_unittest.cc
@@ -189,15 +189,13 @@
}
void ChangeRequestPriority(TestRequest* request,
- net::RequestPriority new_priority,
- int intra_priority = 0) {
+ net::RequestPriority new_priority) {
scoped_refptr<FakeResourceMessageFilter> filter(
new FakeResourceMessageFilter(kChildId));
const ResourceRequestInfoImpl* info = ResourceRequestInfoImpl::ForRequest(
request->url_request());
const GlobalRequestID& id = info->GetGlobalRequestID();
- ResourceHostMsg_DidChangePriority msg(id.request_id, new_priority,
- intra_priority);
+ ResourceHostMsg_DidChangePriority msg(id.request_id, new_priority);
bool ok = false;
rdh_.OnMessageReceived(msg, filter.get(), &ok);
EXPECT_TRUE(ok);
@@ -456,28 +454,6 @@
EXPECT_FALSE(idle->started());
}
-TEST_F(ResourceSchedulerTest, HigherIntraPriorityGoesToFrontOfQueue) {
- // Dummies to enforce scheduling.
- scoped_ptr<TestRequest> high(NewRequest("http://host/high", net::HIGHEST));
- scoped_ptr<TestRequest> low(NewRequest("http://host/high", net::LOWEST));
-
- const int kMaxNumDelayableRequestsPerClient = 10; // Should match the .cc.
- ScopedVector<TestRequest> lows;
- for (int i = 0; i < kMaxNumDelayableRequestsPerClient; ++i) {
- string url = "http://host/low" + base::IntToString(i);
- lows.push_back(NewRequest(url.c_str(), net::IDLE));
- }
-
- scoped_ptr<TestRequest> request(NewRequest("http://host/req", net::IDLE));
- EXPECT_FALSE(request->started());
-
- ChangeRequestPriority(request.get(), net::IDLE, 1);
- EXPECT_FALSE(request->started());
-
- scheduler_.OnWillInsertBody(kChildId, kRouteId);
- EXPECT_TRUE(request->started());
-}
-
TEST_F(ResourceSchedulerTest, NonHTTPSchedulesImmediately) {
// Dummies to enforce scheduling.
scoped_ptr<TestRequest> high(NewRequest("http://host/high", net::HIGHEST));
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/child/resource_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698