Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2205173002: Merge to M53: Account for video rotation in OnVideoNaturalSizeChange() (Closed)

Created:
4 years, 4 months ago by sandersd (OOO until July 31)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge to M53: Account for video rotation in OnVideoNaturalSizeChange() This was always wrong, but now that natural size chages are always emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are causing all non-square rotated videos to render with the wrong aspect ratio. This CL ensures that sizes are treated the same way on this path as in OnMetadata(). BUG=632624 Review-Url: https://codereview.chromium.org/2198403002 Cr-Commit-Position: refs/heads/master@{#409112} (cherry picked from commit 2c4784280c9414e0bd4daf9f0c606f8e52de117a) Committed: https://chromium.googlesource.com/chromium/src/+/f8899e7525aca5ca5abc49c9450fb6e395efeedb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M media/blink/webmediaplayer_impl.cc View 3 chunks +16 lines, -10 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sandersd (OOO until July 31)
4 years, 4 months ago (2016-08-03 01:02:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8899e7525aca5ca5abc49c9450fb6e395efeedb.

Powered by Google App Engine
This is Rietveld 408576698