Account for video rotation in OnVideoNaturalSizeChange()

Account for video rotation in OnVideoNaturalSizeChange()

This was always wrong, but now that natural size chages are always
emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are
causing all non-square rotated videos to render with the wrong
aspect ratio.

This CL ensures that sizes are treated the same way on this path as
in OnMetadata().

BUG=632624
Committed: https://crrev.com/2c4784280c9414e0bd4daf9f0c606f8e52de117a
Cr-Commit-Position: refs/heads/master@{#409112}

[sandersd (OOO until July 31), 2016-08-01 23:29:35]

sandersd@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-08-01 23:32:51]

https://codereview.chromium.org/2198403002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2198403002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1130: gfx::Size rotated_size = size;
Probably this should be deduped into a GetRotationCorrectedSize() or similar
function.

[sandersd (OOO until July 31), 2016-08-01 23:55:19]

PTAL.

https://codereview.chromium.org/2198403002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2198403002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1130: gfx::Size rotated_size = size;
On 2016/08/01 23:32:51, DaleCurtis wrote:
> Probably this should be deduped into a GetRotationCorrectedSize() or similar
> function.

Done.

[DaleCurtis, 2016-08-01 23:57:16]

lgtm

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:126: gfx::Size RotatedVideoSize(VideoRotation
rotation, gfx::Size natural_size) {
Function name should be an action; i.e. GetRotatationCorrectedVideoSize.

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:127: if (rotation == VIDEO_ROTATION_90 ||
rotation == VIDEO_ROTATION_270)
Ternary?

[sandersd (OOO until July 31), 2016-08-02 00:00:42]

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:126: gfx::Size RotatedVideoSize(VideoRotation
rotation, gfx::Size natural_size) {
On 2016/08/01 23:57:16, DaleCurtis wrote:
> Function name should be an action; i.e. GetRotatationCorrectedVideoSize. 

Done.

https://codereview.chromium.org/2198403002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:127: if (rotation == VIDEO_ROTATION_90 ||
rotation == VIDEO_ROTATION_270)
On 2016/08/01 23:57:16, DaleCurtis wrote:
> Ternary?

I didn't find a different way to express this that was any easier to read.

[sandersd (OOO until July 31), 2016-08-02 00:01:20]

The CQ bit was checked by sandersd@chromium.org

[sandersd (OOO until July 31), 2016-08-02 00:01:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2198403002/#ps40001
(title: "Account for video rotation in OnVideoNaturalSizeChange()")

[commit-bot: I haz the power, 2016-08-02 00:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:19:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-02 01:21:22]

Description was changed from

==========
Account for video rotation in OnVideoNaturalSizeChange()

This was always wrong, but now that natural size chages are always
emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are
causing all non-square rotated videos to render with the wrong
aspect ratio.

This CL ensures that sizes are treated the same way on this path as
in OnMetadata().

BUG=632624
==========

to

==========
Account for video rotation in OnVideoNaturalSizeChange()

This was always wrong, but now that natural size chages are always
emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are
causing all non-square rotated videos to render with the wrong
aspect ratio.

This CL ensures that sizes are treated the same way on this path as
in OnMetadata().

BUG=632624

Committed: https://crrev.com/2c4784280c9414e0bd4daf9f0c606f8e52de117a
Cr-Commit-Position: refs/heads/master@{#409112}
==========

[commit-bot: I haz the power, 2016-08-02 01:21:23]

Patchset 3 (id:??) landed as
https://crrev.com/2c4784280c9414e0bd4daf9f0c606f8e52de117a
Cr-Commit-Position: refs/heads/master@{#409112}