Implement delete button in action bar for password entry editor

Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that deletes the saved account when clicked.

BUG=619868
Committed: https://crrev.com/59707b39651fc3a3985640a2f00325ef5575bcb0
Cr-Commit-Position: refs/heads/master@{#410319}

[dozsa, 2016-08-03 13:02:41]

Description was changed from

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868
==========

to

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868
==========

[dozsa, 2016-08-03 13:02:42]

dozsa@google.com changed reviewers:
+ tedchoc@chromium.org, twellington@chromium.org

[dozsa, 2016-08-03 13:03:10]

Hello,

Could you please take a look over this CL?

Best,
Paula

[Theresa, 2016-08-04 17:02:44]

https://codereview.chromium.org/2205163003/diff/1/chrome/android/java/res/men...
File chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml
(right):

https://codereview.chromium.org/2205163003/diff/1/chrome/android/java/res/men...
chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml:11:
android:icon="@drawable/ic_delete"
This looks the same as btn_trash - any way we can reuse that and just tint it
white if it needs to be white?

[dozsa, 2016-08-05 08:12:21]

dozsa@google.com changed reviewers:
+ vabr@chromium.org

[dozsa, 2016-08-05 11:45:32]

https://codereview.chromium.org/2205163003/diff/1/chrome/android/java/res/men...
File chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml
(right):

https://codereview.chromium.org/2205163003/diff/1/chrome/android/java/res/men...
chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml:11:
android:icon="@drawable/ic_delete"
On 2016/08/04 17:02:43, Theresa Wellington wrote:
> This looks the same as btn_trash - any way we can reuse that and just tint it
> white if it needs to be white?

It turns out there was already a white trash icon in the resources, so I just
changed it to that.

[dozsa, 2016-08-05 12:33:56]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 12:34:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dozsa, 2016-08-05 12:49:02]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 12:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 13:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 13:35:37]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-08-05 17:02:00]

lgtm

[Ted C, 2016-08-06 00:23:55]

lgtm

https://codereview.chromium.org/2205163003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
(right):

https://codereview.chromium.org/2205163003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:90:
removeItem();
you should probably return true here

[vabr (Chromium), 2016-08-08 07:11:46]

You don't need my approval, Paula, but LGTM nevertheless (assuming that Ted's
comment gets addressed).

Thanks!
Vaclav

[dozsa, 2016-08-08 08:13:10]

https://codereview.chromium.org/2205163003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
(right):

https://codereview.chromium.org/2205163003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:90:
removeItem();
On 2016/08/06 00:23:55, Ted C wrote:
> you should probably return true here

Done.

[dozsa, 2016-08-08 08:13:14]

The CQ bit was checked by dozsa@google.com

[dozsa, 2016-08-08 08:13:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, twellington@chromium.org, vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2205163003/#ps80001
(title: "Address comment")

[commit-bot: I haz the power, 2016-08-08 08:13:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 08:56:46]

Description was changed from

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868
==========

to

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868
==========

[commit-bot: I haz the power, 2016-08-08 08:56:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-08 08:58:42]

Description was changed from

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868
==========

to

==========
Implement delete button in action bar for password entry editor

This CL adds a delete icon in the action bar for PasswordEntryEditor that
deletes the saved account when clicked.

BUG=619868

Committed: https://crrev.com/59707b39651fc3a3985640a2f00325ef5575bcb0
Cr-Commit-Position: refs/heads/master@{#410319}
==========

[commit-bot: I haz the power, 2016-08-08 08:58:45]

Patchset 5 (id:??) landed as
https://crrev.com/59707b39651fc3a3985640a2f00325ef5575bcb0
Cr-Commit-Position: refs/heads/master@{#410319}