chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml - Issue 2205163003: Implement delete button in action bar for password entry editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml

Issue 2205163003: Implement delete button in action bar for password entry editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor_interactive.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml

diff --git a/chrome/android/java/res/menu/download_manager_menu.xml b/chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml

similarity index 57%

copy from chrome/android/java/res/menu/download_manager_menu.xml

copy to chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml

index bc927a5d040352ea8a972d009e87da328e4b30af..ccd3c8233d3a651842b24b7bc1b7aeba499ac5a5 100644

--- a/chrome/android/java/res/menu/download_manager_menu.xml

+++ b/chrome/android/java/res/menu/password_entry_editor_action_bar_menu.xml

@@ -7,9 +7,9 @@

xmlns:chrome="http://schemas.android.com/apk/res-auto" >

<item

- android:id="@+id/close_menu_id"

- android:icon="@drawable/btn_close"

- android:title="@string/close"

+ android:id="@+id/action_delete_saved_password"

+ android:icon="@drawable/ic_delete_white_24dp"

+ android:title="@string/password_entry_editor_delete_stored_password_action_title"

+ android:contentDescription="@string/password_entry_editor_delete_stored_password"

chrome:showAsAction="ifRoom"/>

</menu>