src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2204963002: [wasm] Use the Float64Max/Min machine operators to implement F64Max/Min.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2204963002: [wasm] Use the Float64Max/Min machine operators to implement F64Max/Min. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 6e35ae0554363e34ebac989b7f7fedcaf1bec139..ea04ec056a0f22d69182c65c835543756fa0bacc 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -4693,7 +4693,8 @@ void LCodeGen::EmitNumberUntagD(LNumberUntagD* instr, Register input_reg,

DeoptimizeIf(not_equal, instr,

DeoptimizeReason::kNotAHeapNumberUndefined);

- __ Pcmpeqd(result_reg, result_reg);

+ __ xorpd(result_reg, result_reg);

Benedikt Meurer 2016/08/03 03:24:34 Please use Xorpd and Divsd here.

ahaas 2016/08/03 07:17:14 Done.

+ __ divsd(result_reg, result_reg);

__ jmp(&done, Label::kNear);

}

} else {

« src/compiler/x64/code-generator-x64.cc ('K') | « src/compiler/x64/code-generator-x64.cc ('k') | no next file » | no next file with comments »