Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 2204963002: [wasm] Use the Float64Max/Min machine operators to implement F64Max/Min. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/x64/code-generator-x64.cc
diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc
index 0ab84e412be54008c1cf154eee2c9c0a14eb480c..301f690a7acb3abbc1a62379ddf029665c201c5d 100644
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -170,7 +170,10 @@ class OutOfLineLoadNaN final : public OutOfLineCode {
OutOfLineLoadNaN(CodeGenerator* gen, XMMRegister result)
: OutOfLineCode(gen), result_(result) {}
- void Generate() final { __ Pcmpeqd(result_, result_); }
+ void Generate() final {
+ __ xorpd(result_, result_);
Benedikt Meurer 2016/08/03 03:24:34 Please use Xorpd and Divsd here.
ahaas 2016/08/03 07:17:14 Done.
+ __ divsd(result_, result_);
+ }
private:
XMMRegister const result_;

Powered by Google App Engine
This is Rietveld 408576698