Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply comments on #12 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc
diff --git a/components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc b/components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc
index 5f2cbb052828fa561059324cb72db3a8f9e32f9c..f5b4837e904b79318d9d4ccc702fe105ec5a5419 100644
--- a/components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc
+++ b/components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc
@@ -16,9 +16,12 @@ namespace {
constexpr base::char16 kRegistryPath[] = L"Foo\\TestStore";
constexpr base::char16 kStoreKey[] = L"test_store_key";
-// MACs are 32 characters long.
-constexpr char kTestStringA[] = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
-constexpr char kTestStringB[] = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
+// MACs are 32 characters long, which stored in the registry are 64 characters
+// long due to 8-bit to 16-bit char conversion.
gab 2016/09/23 14:01:18 This is still unexpected to me, i.e. this is passe
proberge 2016/09/23 15:24:34 My bad, I completely misunderstood what was going
gab 2016/09/23 15:56:58 Ah ok, now that makes more sense, thanks!
+constexpr char kTestStringA[] =
+ "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+constexpr char kTestStringB[] =
+ "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
constexpr char kAtomicPrefPath[] = "path1";
constexpr char kSplitPrefPath[] = "extension";
@@ -114,4 +117,4 @@ TEST_F(RegistryHashStoreContentsWinTest, TestReset) {
split_macs.clear();
EXPECT_FALSE(contents->GetSplitMacs(kSplitPrefPath, &split_macs));
EXPECT_EQ(0U, split_macs.size());
-}
+}

Powered by Google App Engine
This is Rietveld 408576698