Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply comments on #12 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/user_prefs/tracked/registry_hash_store_contents_win.h" 5 #include "components/user_prefs/tracked/registry_hash_store_contents_win.h"
6 6
7 #include "base/strings/string16.h" 7 #include "base/strings/string16.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/test/test_reg_util_win.h" 9 #include "base/test/test_reg_util_win.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "base/win/registry.h" 11 #include "base/win/registry.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace { 14 namespace {
15 15
16 constexpr base::char16 kRegistryPath[] = L"Foo\\TestStore"; 16 constexpr base::char16 kRegistryPath[] = L"Foo\\TestStore";
17 constexpr base::char16 kStoreKey[] = L"test_store_key"; 17 constexpr base::char16 kStoreKey[] = L"test_store_key";
18 18
19 // MACs are 32 characters long. 19 // MACs are 32 characters long, which stored in the registry are 64 characters
20 constexpr char kTestStringA[] = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; 20 // long due to 8-bit to 16-bit char conversion.
gab 2016/09/23 14:01:18 This is still unexpected to me, i.e. this is passe
proberge 2016/09/23 15:24:34 My bad, I completely misunderstood what was going
gab 2016/09/23 15:56:58 Ah ok, now that makes more sense, thanks!
21 constexpr char kTestStringB[] = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"; 21 constexpr char kTestStringA[] =
22 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
23 constexpr char kTestStringB[] =
24 "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
22 25
23 constexpr char kAtomicPrefPath[] = "path1"; 26 constexpr char kAtomicPrefPath[] = "path1";
24 constexpr char kSplitPrefPath[] = "extension"; 27 constexpr char kSplitPrefPath[] = "extension";
25 28
26 class RegistryHashStoreContentsWinTest : public testing::Test { 29 class RegistryHashStoreContentsWinTest : public testing::Test {
27 protected: 30 protected:
28 RegistryHashStoreContentsWinTest() {} 31 RegistryHashStoreContentsWinTest() {}
29 32
30 void SetUp() override { 33 void SetUp() override {
31 registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER); 34 registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 110
108 contents->Reset(); 111 contents->Reset();
109 112
110 stored_mac.clear(); 113 stored_mac.clear();
111 EXPECT_FALSE(contents->GetMac(kAtomicPrefPath, &stored_mac)); 114 EXPECT_FALSE(contents->GetMac(kAtomicPrefPath, &stored_mac));
112 EXPECT_TRUE(stored_mac.empty()); 115 EXPECT_TRUE(stored_mac.empty());
113 116
114 split_macs.clear(); 117 split_macs.clear();
115 EXPECT_FALSE(contents->GetSplitMacs(kSplitPrefPath, &split_macs)); 118 EXPECT_FALSE(contents->GetSplitMacs(kSplitPrefPath, &split_macs));
116 EXPECT_EQ(0U, split_macs.size()); 119 EXPECT_EQ(0U, split_macs.size());
117 } 120 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698