chrome/browser/safe_browsing/database_manager_unittest.cc - Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/database_manager_unittest.cc

Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: changes for review #2 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/database_manager.h ('K') | « chrome/browser/safe_browsing/database_manager.cc ('k') | chrome/browser/safe_browsing/protocol_manager.h » ('j') | chrome/browser/safe_browsing/protocol_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/database_manager_unittest.cc

diff --git a/chrome/browser/safe_browsing/database_manager_unittest.cc b/chrome/browser/safe_browsing/database_manager_unittest.cc

index 192c6926850e266542bb6e1fc2d944a5d17ae105..98ade110604cb850a06e27babdd84c42d8b64b34 100644

--- a/chrome/browser/safe_browsing/database_manager_unittest.cc

+++ b/chrome/browser/safe_browsing/database_manager_unittest.cc

@@ -80,7 +80,6 @@ bool SafeBrowsingDatabaseManagerTest::RunSBHashTest(

const SBFullHashResult full_hash_result = {

same_full_hash,

result_list,

- 0

};

std::vector<SBFullHashResult> fake_results(1, full_hash_result);