Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases.

chrome/browser/safe_browsing/database_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/safe_browsing/database_manager.h"
@@ skipping 62 matching lines @@
           std::vector<GURL>(),
           std::vector<SBFullHash>(1, same_full_hash),
           NULL,
           list_type,
           expected_threats);
   db_manager_->checks_.insert(check);
 
   const SBFullHashResult full_hash_result = {
       same_full_hash,
       result_list,
-      0
   };
 
   std::vector<SBFullHashResult> fake_results(1, full_hash_result);
   bool result = db_manager_->HandleOneCheck(check, fake_results);
   db_manager_->checks_.erase(check);
   delete check;
   return result;
 }
 
 TEST_F(SafeBrowsingDatabaseManagerTest, CheckCorrespondsListType) {
@@ skipping 10 matching lines @@
   std::vector<SBThreatType> multiple_threats;
   multiple_threats.push_back(SB_THREAT_TYPE_URL_MALWARE);
   multiple_threats.push_back(SB_THREAT_TYPE_URL_PHISHING);
   EXPECT_FALSE(RunSBHashTest(safe_browsing_util::MALWARE,
                              multiple_threats,
                              safe_browsing_util::kBinUrlList));
   EXPECT_TRUE(RunSBHashTest(safe_browsing_util::MALWARE,
                             multiple_threats,
                             safe_browsing_util::kMalwareList));
 }