Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5171)

Unified Diff: chrome/browser/safe_browsing/protocol_parser_unittest.cc

Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_parser_unittest.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser_unittest.cc b/chrome/browser/safe_browsing/protocol_parser_unittest.cc
index c20c4cea44c227380ee3c6f665fb52036547459d..87672e17571e5dee4d944f570818861f144f4bfa 100644
--- a/chrome/browser/safe_browsing/protocol_parser_unittest.cc
+++ b/chrome/browser/safe_browsing/protocol_parser_unittest.cc
@@ -489,7 +489,6 @@ TEST(SafeBrowsingProtocolParsingTest, TestGetHashWithUnknownList) {
EXPECT_EQ(memcmp("12345678901234567890123456789012",
&full_hashes[0].hash, sizeof(SBFullHash)), 0);
EXPECT_EQ(full_hashes[0].list_name, "goog-phish-shavar");
- EXPECT_EQ(full_hashes[0].add_chunk_id, 1);
hash_response += "goog-malware-shavar:7:32\n"
"abcdefghijklmnopqrstuvwxyz123457";
@@ -502,11 +501,9 @@ TEST(SafeBrowsingProtocolParsingTest, TestGetHashWithUnknownList) {
EXPECT_EQ(memcmp("12345678901234567890123456789012",
&full_hashes[0].hash, sizeof(SBFullHash)), 0);
EXPECT_EQ(full_hashes[0].list_name, "goog-phish-shavar");
- EXPECT_EQ(full_hashes[0].add_chunk_id, 1);
EXPECT_EQ(memcmp("abcdefghijklmnopqrstuvwxyz123457",
&full_hashes[1].hash, sizeof(SBFullHash)), 0);
EXPECT_EQ(full_hashes[1].list_name, "goog-malware-shavar");
- EXPECT_EQ(full_hashes[1].add_chunk_id, 7);
}
TEST(SafeBrowsingProtocolParsingTest, TestFormatHash) {

Powered by Google App Engine
This is Rietveld 408576698