chrome/browser/safe_browsing/protocol_parser.cc - Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/database_manager.cc ('K') | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_parser.cc

diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc

index 1fb64ef7521eb8ac9a62748d8eec75e055ad4eab..a6e82a659222d50cc103c2bc6804914da499fa55 100644

--- a/chrome/browser/safe_browsing/protocol_parser.cc

+++ b/chrome/browser/safe_browsing/protocol_parser.cc

@@ -66,7 +66,8 @@ bool SafeBrowsingProtocolParser::ParseGetHash(

SBFullHashResult full_hash;

full_hash.list_name = cmd_parts[0];

- full_hash.add_chunk_id = atoi(cmd_parts[1].c_str());

+ // Ignore add_chunk_id (cmd_parts[1]), as we no longer use it with SB 2.3

+ // caching rules.

Scott Hess - ex-Googler 2014/04/01 22:08:36 I'd rephrase to "Ignore cmd_parts[1] (add_chunk_id

mattm 2014/04/03 01:38:12 Done.

int full_hash_len = atoi(cmd_parts[2].c_str());

// Ignore hash results from lists we don't recognize.